fix: resolve docstring duplication, bare except, and timestamp format issues#112
Open
Jah-yee wants to merge 2 commits intoEverMind-AI:mainfrom
Open
fix: resolve docstring duplication, bare except, and timestamp format issues#112Jah-yee wants to merge 2 commits intoEverMind-AI:mainfrom
Jah-yee wants to merge 2 commits intoEverMind-AI:mainfrom
Conversation
Fixes EverMind-AI#78: Search API now iterates over all requested memory_types instead of only using the first one. Changes: - get_keyword_search_results: now iterates over all supported memory_types (EPISODIC_MEMORY, EVENT_LOG, FORESIGHT) and merges results with deduplication - get_vector_search_results: now iterates over all supported memory_types and merges results with deduplication - For unsupported types (e.g., profile which is stored in MongoDB), logs an info message and skips instead of erroring out Behavior: - When multiple memory_types are provided, all supported types are searched - Results are merged and deduplicated by id - The first memory_type is still used for metrics/logging purposes
… issues - Fix EverMind-AI#50: Remove duplicate 'rrf' entry in demo docstring - Fix EverMind-AI#107: Replace bare except with except Exception in mem_db_operations.py - Fix EverMind-AI#107: Replace bare except with except Exception in episodic_memory_milvus_repository.py - Fix EverMind-AI#48: Add ISO 8601 timestamp format requirement to episode_mem_prompts.py All modified files pass Python syntax validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
This PR addresses multiple issues to improve code quality and consistency:
Changes
1. Fix #50: Remove duplicate rrf entry in demo docstring
demo/utils/simple_memory_manager.py(line 247-251)2. Fix #107: Replace bare except with except Exception
src/biz_layer/mem_db_operations.py(line 146)src/infra_layer/adapters/out/search/repository/episodic_memory_milvus_repository.py(line 127)Reason: Bare
except:catchesBaseExceptionincludingKeyboardInterruptandSystemExit. Usingexcept Exception:preserves fallback behavior while allowing system exceptions to propagate.3. Fix #48: Enforce ISO 8601 timestamp format
src/memory_layer/prompts/en/episode_mem_prompts.pyto require strict ISO 8601 format:Reason: Previous timestamps had inconsistent formats causing parsing issues.
Local Testing
All modified files pass Python syntax validation:
Warmly,
Spark (on behalf of Spark Lab)
感谢你们的奉献，希望能提供帮助。如果我解决得有问题或有待商妥的地方，请在下面留言，我会来处理。